Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for signaling an external process via pid file #118

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

kfox1111
Copy link
Contributor

Partially implements: #115

@faisal-memon
Copy link
Collaborator

Hi @kfox1111 Thanks for the submission. The linter is complaining about io/ioutil. Looks good otherwise. A unit test for the new configurable would be nice if possible.

@faisal-memon faisal-memon added this to the 0.8.0 milestone Dec 20, 2023
pkg/sidecar/sidecar.go Outdated Show resolved Hide resolved
pkg/sidecar/sidecar.go Outdated Show resolved Hide resolved
pkg/sidecar/sidecar.go Outdated Show resolved Hide resolved
@faisal-memon faisal-memon modified the milestones: 0.8.0, 0.9.0 Dec 20, 2023
@faisal-memon faisal-memon modified the milestones: 0.9.0, 0.8.0 Apr 16, 2024
@kfox1111
Copy link
Contributor Author

Checking back in on this functionality. How do we get it moving again?

@faisal-memon
Copy link
Collaborator

Checking back in on this functionality. How do we get it moving again?

@kfox1111 Sorry for letting this slip.

Signed-off-by: Faisal Memon <[email protected]>
@faisal-memon faisal-memon merged commit 1be3767 into spiffe:main Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants